diff options
| author | Szymon Szukalski <szymon@skas.io> | 2024-10-25 12:05:03 +1100 |
|---|---|---|
| committer | Szymon Szukalski <szymon@skas.io> | 2024-10-25 12:05:03 +1100 |
| commit | 5d5ca66762513dccfbc4e76782e81bc593258c68 (patch) | |
| tree | 4ad253977f23d0cb08b4d65e6895151aceb4871e /lib/family_tree.rb | |
| parent | 29fe91901a188af552a0bbaeb59eaf056fbe385d (diff) | |
Update README and fix incorrect outputs
- Don't output anything if the relationship is unsupported
- Fail if we're adding a child via the father to a family
Diffstat (limited to 'lib/family_tree.rb')
| -rw-r--r-- | lib/family_tree.rb | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/family_tree.rb b/lib/family_tree.rb index 5ba8c72..9850280 100644 --- a/lib/family_tree.rb +++ b/lib/family_tree.rb @@ -38,6 +38,8 @@ class FamilyTree parent = result[:person] parent_of_family = result[:parent_of_family] + return 'PERSON_NOT_FOUND' if parent.is_a?(NilPerson) + if parent_of_family.nil? || parent_of_family.mother.is_a?(NilPerson) || parent_of_family.father.eql?(parent) return 'CHILD_ADDITION_FAILED' end @@ -82,7 +84,7 @@ class FamilyTree when 'brother-in-law' handle_brother_in_law_relationship(person, child_of_family) else - 'UNSUPPORTED_RELATIONSHIP' + false end end @@ -130,7 +132,7 @@ class FamilyTree daughters = children.select { |child| child.gender == Gender::FEMALE } daughters.empty? ? 'NONE' : daughters.map(&:name).join(' ') else - 'UNSUPPORTED_RELATIONSHIP' + false end end |
