summaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorSzymon Szukalski <szymon@skas.io>2024-07-26 11:43:56 +1000
committerSzymon Szukalski <szymon@skas.io>2024-07-26 11:43:56 +1000
commit1abae6d1e41659ebe3230352c58e0cf0550f19eb (patch)
treed8a53520348ef4079530db2e23354b3fc04b4814 /src/test
parent40fd0f10181909719f2541d62965dbcbc8e91078 (diff)
Add test not found handling to /aggregate endpoint
Diffstat (limited to 'src/test')
-rw-r--r--src/test/java/com/stileeducation/markr/controller/AggregateEndpointTests.java74
-rw-r--r--src/test/java/com/stileeducation/markr/controller/TestResultsControllerTest.java1
-rw-r--r--src/test/java/com/stileeducation/markr/service/TestResultsServiceTest.java4
3 files changed, 77 insertions, 2 deletions
diff --git a/src/test/java/com/stileeducation/markr/controller/AggregateEndpointTests.java b/src/test/java/com/stileeducation/markr/controller/AggregateEndpointTests.java
new file mode 100644
index 0000000..7776a75
--- /dev/null
+++ b/src/test/java/com/stileeducation/markr/controller/AggregateEndpointTests.java
@@ -0,0 +1,74 @@
+package com.stileeducation.markr.controller;
+
+import com.stileeducation.markr.MarkrApplication;
+import com.stileeducation.markr.dto.AggregateResponseDTO;
+import com.stileeducation.markr.exception.TestNotFoundException;
+import com.stileeducation.markr.service.TestResultsService;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.boot.test.web.client.TestRestTemplate;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.test.context.ActiveProfiles;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.mockito.BDDMockito.given;
+
+@SpringBootTest(classes = MarkrApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
+@AutoConfigureMockMvc
+@ActiveProfiles("test")
+public class AggregateEndpointTests {
+
+ @Autowired
+ private TestRestTemplate restTemplate;
+
+ @MockBean
+ private TestResultsService testResultsService;
+
+ @Test
+ public void testGetAggregatedResults_notFound() throws Exception {
+ String testId = "1234";
+ given(testResultsService.aggregateTestResults(testId))
+ .willThrow(new TestNotFoundException("Test with ID " + testId + " not found"));
+
+ String url = "/results/" + testId + "/aggregate";
+ ResponseEntity<AggregateResponseDTO> response = restTemplate.getForEntity(url, AggregateResponseDTO.class);
+
+ assertEquals(HttpStatus.NOT_FOUND, response.getStatusCode());
+ assertNull(response.getBody());
+ }
+
+
+ @Test
+ public void testGetAggregatedResults() throws Exception {
+ String testId = "test123";
+ AggregateResponseDTO mockResponse = new AggregateResponseDTO();
+ mockResponse.setMin(10.0);
+ mockResponse.setMax(80.0);
+ mockResponse.setMean(45.0);
+ mockResponse.setStddev(25.0);
+ mockResponse.setP25(17.5);
+ mockResponse.setP50(25.0);
+ mockResponse.setP75(72.5);
+ mockResponse.setCount(6);
+
+ given(testResultsService.aggregateTestResults(testId)).willReturn(mockResponse);
+
+ String url = "/results/" + testId + "/aggregate";
+ ResponseEntity<AggregateResponseDTO> response = restTemplate.getForEntity(url, AggregateResponseDTO.class);
+
+ assertEquals(HttpStatus.OK, response.getStatusCode());
+ assertEquals(mockResponse.getMin(), response.getBody().getMin());
+ assertEquals(mockResponse.getMax(), response.getBody().getMax());
+ assertEquals(mockResponse.getMean(), response.getBody().getMean());
+ assertEquals(mockResponse.getStddev(), response.getBody().getStddev());
+ assertEquals(mockResponse.getP25(), response.getBody().getP25());
+ assertEquals(mockResponse.getP50(), response.getBody().getP50());
+ assertEquals(mockResponse.getP75(), response.getBody().getP75());
+ assertEquals(mockResponse.getCount(), response.getBody().getCount());
+ }
+}
diff --git a/src/test/java/com/stileeducation/markr/controller/TestResultsControllerTest.java b/src/test/java/com/stileeducation/markr/controller/TestResultsControllerTest.java
index 3b491cc..efb20d6 100644
--- a/src/test/java/com/stileeducation/markr/controller/TestResultsControllerTest.java
+++ b/src/test/java/com/stileeducation/markr/controller/TestResultsControllerTest.java
@@ -47,6 +47,7 @@ public class TestResultsControllerTest {
return stringWriter.toString();
}
+
@Test
void testSupportedMediaType() throws Exception {
// Given
diff --git a/src/test/java/com/stileeducation/markr/service/TestResultsServiceTest.java b/src/test/java/com/stileeducation/markr/service/TestResultsServiceTest.java
index 844c739..ad4e476 100644
--- a/src/test/java/com/stileeducation/markr/service/TestResultsServiceTest.java
+++ b/src/test/java/com/stileeducation/markr/service/TestResultsServiceTest.java
@@ -151,7 +151,7 @@ class TestResultsServiceTest {
@Test
void calculateStandardDeviationOfTestResults() {
double standardDeviationOfTestResults = testResultsService.calculateStandardDeviationOfTestResults(test1, test1Results);
- assertEquals(25, standardDeviationOfTestResults, 0.01);
+ assertEquals(25.0, standardDeviationOfTestResults, 0.01);
}
@Test
@@ -163,7 +163,7 @@ class TestResultsServiceTest {
@Test
void calculate50thPercentile() {
double percentile = testResultsService.calculate50thPercentile(test1, test1Results);
- assertEquals(45, percentile, 0.01);
+ assertEquals(45.0, percentile, 0.01);
}
@Test