diff options
| author | Szymon Szukalski <szymon@skas.io> | 2024-07-25 20:54:41 +1000 |
|---|---|---|
| committer | Szymon Szukalski <szymon@skas.io> | 2024-07-25 20:54:41 +1000 |
| commit | cf4edfcb4bc7d0d02cefa861a95812315f092a66 (patch) | |
| tree | 5a3996a51a7ced388a6d7f4fa5c0d2a84124010e /src/main/java/com/stileeducation/markr/controller/TestResultsController.java | |
| parent | aa9bdd514ab90d0da0391b879255a22c29450e9a (diff) | |
Removed unused variables and switch to constructor injection
Diffstat (limited to 'src/main/java/com/stileeducation/markr/controller/TestResultsController.java')
| -rw-r--r-- | src/main/java/com/stileeducation/markr/controller/TestResultsController.java | 29 |
1 files changed, 3 insertions, 26 deletions
diff --git a/src/main/java/com/stileeducation/markr/controller/TestResultsController.java b/src/main/java/com/stileeducation/markr/controller/TestResultsController.java index f5b6070..9b84e93 100644 --- a/src/main/java/com/stileeducation/markr/controller/TestResultsController.java +++ b/src/main/java/com/stileeducation/markr/controller/TestResultsController.java @@ -3,12 +3,7 @@ package com.stileeducation.markr.controller; import com.stileeducation.markr.dto.AggregateResponseDTO; import com.stileeducation.markr.dto.ImportResponseDTO; import com.stileeducation.markr.dto.MCQTestResultsDTO; -import com.stileeducation.markr.repository.TestRepository; -import com.stileeducation.markr.repository.TestResultRepository; -import com.stileeducation.markr.service.StudentService; import com.stileeducation.markr.service.TestResultsService; -import com.stileeducation.markr.service.TestService; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; import org.springframework.http.converter.HttpMessageNotReadableException; @@ -23,29 +18,13 @@ public class TestResultsController { public static final String IMPORT_ENDPOINT = "/import"; public static final String AGGREGATE_ENDPOINT = "/results/{test-id}/aggregate"; - @Autowired - private StudentService studentService; - - @Autowired - private TestService testService; - - @Autowired - private TestResultsService testResultsService; - - @Autowired - private TestRepository testRepository; - - @Autowired - private TestResultRepository testResultRepository; + private final TestResultsService testResultsService; public TestResultsController(TestResultsService testResultsService) { this.testResultsService = testResultsService; } - @PostMapping( - value = IMPORT_ENDPOINT, - consumes = "text/xml+markr", - produces = "application/json") + @PostMapping(value = IMPORT_ENDPOINT, consumes = "text/xml+markr", produces = "application/json") public ResponseEntity<ImportResponseDTO> postTestResults(@Validated @RequestBody MCQTestResultsDTO testResults) { ImportResponseDTO response = testResultsService.processTestResults(testResults); if ("failure".equals(response.getStatus())) { @@ -54,9 +33,7 @@ public class TestResultsController { return new ResponseEntity<>(response, HttpStatus.OK); } - @GetMapping( - value = AGGREGATE_ENDPOINT, - produces = "application/json") + @GetMapping(value = AGGREGATE_ENDPOINT, produces = "application/json") public AggregateResponseDTO getAggregatedResults(@PathVariable("test-id") String testId) { return testResultsService.aggregateTestResults(testId); } |
