1 files changed, 67 insertions, 27 deletions
diff --git a/spec/action_file_executor_spec.rb b/spec/action_file_executor_spec.rb
index cab34b3..ce2fa11 100644
--- a/spec/action_file_executor_spec.rb
+++ b/spec/action_file_executor_spec.rb
@@ -2,17 +2,16 @@
 
 require 'tempfile'
 require_relative '../lib/action_file_executor'
-require_relative '../lib/family_tree_manager'
 
 RSpec.describe ActionFileExecutor do
   let(:invalid_file_path) { 'non_existent_file.txt' }
-  let(:family_tree_manager) { instance_double('FamilyTreeManager') }
+  let(:family_tree) { instance_double('FamilyTree') }
   let(:tempfile) { Tempfile.new('actions.txt') }
 
   before do
-    allow(FamilyTreeManager).to receive(:instance).and_return(family_tree_manager)
-    allow(family_tree_manager).to receive(:add_child)
-    allow(family_tree_manager).to receive(:query_hierarchy)
+    allow(FamilyTree).to receive(:instance).and_return(family_tree)
+    allow(family_tree).to receive(:add_child)
+    allow(family_tree).to receive(:get_relationship).and_return([])
   end
 
   after do
@@ -21,6 +20,13 @@ RSpec.describe ActionFileExecutor do
   end
 
   describe '#initialize' do
+    context 'when the file exists' do
+      it 'initializes successfully' do
+        action_file_executor = ActionFileExecutor.new(tempfile.path)
+        expect(action_file_executor).to be_an_instance_of(ActionFileExecutor)
+      end
+    end
+
     context 'when the file does not exist' do
       it 'prints an error message and exits' do
         expect do
@@ -28,49 +34,83 @@ RSpec.describe ActionFileExecutor do
         end.to output("Error: The file 'non_existent_file.txt' does not exist.\n").to_stdout.and raise_error(SystemExit)
       end
     end
+  end
 
-    context 'when the file exists' do
-      it 'initializes successfully' do
-        tempfile.puts('ADD_CHILD Mother Child Male')
+  describe '#execute_actions' do
+    context 'with a valid file' do
+      before do
+        tempfile.write("ADD_CHILD \"Mother's Name\" \"Child's Name\"\n")
+        tempfile.write("# A comment\n")
+        tempfile.write("\n")
+        tempfile.write("INVALID ACTION\n")
+        tempfile.write("GET_RELATIONSHIP \"Mother's Name\" \"Child's Name\"\n")
         tempfile.rewind
+      end
 
+      it 'processes all lines in the file' do
         action_file_executor = ActionFileExecutor.new(tempfile.path)
-        expect(action_file_executor).to be_an_instance_of(ActionFileExecutor)
+        allow(action_file_executor).to receive(:process_line)
+
+        action_file_executor.execute_actions
+        expect(action_file_executor).to have_received(:process_line).exactly(5).times
+      end
+
+      it 'executes actions for non-empty and non-comment lines' do
+        action_file_executor = ActionFileExecutor.new(tempfile.path)
+        allow(action_file_executor).to receive(:execute_action)
+
+        action_file_executor.execute_actions
+        expect(action_file_executor).to have_received(:execute_action).exactly(3).times
       end
     end
   end
 
-  describe '#execute_actions' do
-    context 'with valid actions' do
-      before do
-        tempfile.puts('ADD_CHILD Mother Child Male')
-        tempfile.puts('GET_RELATIONSHIP Child Maternal-Uncle')
-        tempfile.rewind
+  describe '#process_line' do
+    context 'with a comment line' do
+      it 'does not execute the action' do
+        action_file_executor = ActionFileExecutor.new(tempfile.path)
+        expect(action_file_executor.send(:process_line, '# This is a comment')).to be_nil
       end
+    end
 
-      it 'calls the add_child method on FamilyTreeManager when it encounters the ADD_CHILD action' do
+    context 'with an empty line' do
+      it 'does not execute the action' do
         action_file_executor = ActionFileExecutor.new(tempfile.path)
-        action_file_executor.execute_actions
-        expect(family_tree_manager).to have_received(:add_child).with('Mother', 'Child', 'Male')
+        expect(action_file_executor.send(:process_line, '')).to be_nil
       end
+    end
+  end
 
-      it 'calls the query_hierarchy method on FamilyTreeManager when it encounters the GET_RELATIONSHIP action' do
+  describe '#extract_action_and_params' do
+    it 'returns the action and params from the line' do
+      action_file_executor = ActionFileExecutor.new(tempfile.path)
+      expect(action_file_executor.send(:extract_action_and_params,
+                                       'ADD_CHILD "Mother\'s Name" "Child\'s Name"')).to eq(['ADD_CHILD',
+                                                                                             ["Mother's Name",
+                                                                                              "Child's Name"]])
+    end
+  end
+
+  describe '#execute_action' do
+    context 'with the ADD_CHILD action' do
+      it 'calls the add_child method on FamilyTree' do
         action_file_executor = ActionFileExecutor.new(tempfile.path)
-        action_file_executor.execute_actions
-        expect(family_tree_manager).to have_received(:query_hierarchy).with('Child', 'Maternal-Uncle')
+        action_file_executor.send(:execute_action, 'ADD_CHILD', ["Mother's Name", "Child's Name"])
       end
     end
 
-    context 'with unsupported actions' do
-      before do
-        tempfile.puts('ADD_MOTHER Child Mother')
-        tempfile.rewind
+    context 'with the GET_RELATIONSHIP action' do
+      it 'calls the get_relationship method on FamilyTree' do
+        action_file_executor = ActionFileExecutor.new(tempfile.path)
+        action_file_executor.send(:execute_action, 'GET_RELATIONSHIP', ["Child's Name", 'Maternal-Uncle'])
       end
+    end
 
-      it 'prints an error message when it encounters an unsupported action' do
+    context 'with an unsupported action' do
+      it 'prints an error message' do
         expect do
           action_file_executor = ActionFileExecutor.new(tempfile.path)
-          action_file_executor.execute_actions
+          action_file_executor.send(:execute_action, 'ADD_MOTHER', ["Child's Name", "Mother's Name"])
         end.to output("Ignoring unsupported action: [ADD_MOTHER]\n").to_stdout
       end
     end