From cf4edfcb4bc7d0d02cefa861a95812315f092a66 Mon Sep 17 00:00:00 2001 From: Szymon Szukalski Date: Thu, 25 Jul 2024 20:54:41 +1000 Subject: Removed unused variables and switch to constructor injection --- .../stileeducation/markr/service/TestResultsService.java | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) (limited to 'src/main/java/com/stileeducation/markr/service/TestResultsService.java') diff --git a/src/main/java/com/stileeducation/markr/service/TestResultsService.java b/src/main/java/com/stileeducation/markr/service/TestResultsService.java index 51efe95..0c0fa66 100644 --- a/src/main/java/com/stileeducation/markr/service/TestResultsService.java +++ b/src/main/java/com/stileeducation/markr/service/TestResultsService.java @@ -10,7 +10,6 @@ import com.stileeducation.markr.entity.TestResult; import com.stileeducation.markr.repository.TestResultRepository; import org.apache.commons.math3.stat.descriptive.moment.StandardDeviation; import org.apache.commons.math3.stat.descriptive.rank.Percentile; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; import java.util.List; @@ -21,14 +20,17 @@ public class TestResultsService { public static final boolean IS_BIAS_CORRECTED = false; - @Autowired - private TestResultRepository testResultRepository; + private final TestResultRepository testResultRepository; - @Autowired - private StudentService studentService; + private final StudentService studentService; - @Autowired - private TestService testService; + private final TestService testService; + + public TestResultsService(TestResultRepository testResultRepository, StudentService studentService, TestService testService) { + this.testResultRepository = testResultRepository; + this.studentService = studentService; + this.testService = testService; + } public TestResult findOrCreateTestResult(Student student, Test test, Integer marksAwarded) { Optional optionalTestResult = testResultRepository.findByStudentAndTest(student, test); -- cgit v1.2.3